This repository was archived by the owner on Jun 30, 2021. It is now read-only.
Pull starting slice from redis instead of extrapolating#154
Open
sbwdlihao wants to merge 3 commits intosimplecrypto:masterfrom
Open
Pull starting slice from redis instead of extrapolating#154sbwdlihao wants to merge 3 commits intosimplecrypto:masterfrom
sbwdlihao wants to merge 3 commits intosimplecrypto:masterfrom
Conversation
start index may be not exist when chain first join or rejoin in mine
Closed
Member
There was a problem hiding this comment.
I'm unsure about the correctness of this. In scenarios involving merge-mined blocks this will definitely be wrong at certain times. Effectively, something can occur where "slice 0" has most of the shares, and was rotated by a merge mined block solve. "slice 1" has a small number of shares, and was rotated due to a main network block solve.
The simplest fix is to require the "start_index" value if there are other blocks solved on the same chain already. This has it's own problems tho if the redis database gets wiped.
I'll keep thinking on this. For the large majority of cases tho this should work fine. Thanks for the work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #146